Support general chat #1297
Open
Support general chat #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
force-pushed
the
pr-general-chat
branch
11 times, most recently
from
da55117 to
b38c9bc
Compare
PIG208
force-pushed
the
pr-general-chat
branch
from
b38c9bc to
4bdbc85
Compare
PIG208
force-pushed
the
pr-general-chat
branch
from
4bdbc85 to
02a284d
Compare
|
Will rebase and add screenshots shortly. |
PIG208
force-pushed
the
pr-general-chat
branch
from
02a284d to
b3f2081
Compare
instead of inferring it from a TopicName Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
This helps imply why we don't have the check when displayName is null Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
PIG208
force-pushed
the
pr-general-chat
branch
from
b3f2081 to
bc157cf
Compare
|
Screenshots: Autocomplete
Message list page
Inbox; no resolve button
|
The '#channel > topic' style strings are not supposed to be translated into different languages as they are Zulip's language of expressing the desintation, not something bound to the English language. The string needs to be re-translated in other languages, as the placeholder is now different. See also: zulip#1148 (comment) Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
This will later be useful for checking emptiness if realmEmptyTopicDisplayName is given. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
force-pushed
the
pr-general-chat
branch
from
bc157cf to
49751d6
Compare
This behavior is designed to replace how sending to an empty topic is effectively sending to "(no topic)". The key difference being that the `TopicName.apiValue` is actually empty, instead of being converted to "(no topic)" with `_computeTextNormalized`. Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Look for `allow_empty_topic_name` and `empty_topic_name` under "Feature level 334" in the API Changelog to verify the affected routes: https://zulip.com/api/changelog Fixes: zulip#1250 Signed-off-by: Zixuan James Li <[email protected]>
PIG208
force-pushed
the
pr-general-chat
branch
from
49751d6 to
d88c355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1296.
Fixes: